-
-
Notifications
You must be signed in to change notification settings - Fork 235
DBZ-9516 MongoDB docker image with replica set enabled #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mongodb/6.0/Dockerfile
Outdated
# Copy custom entrypoint script | ||
COPY mongodb-debezium-entrypoint.sh /usr/local/bin/mongodb-debezium-entrypoint.sh | ||
|
||
RUN chmod +x /usr/local/bin/mongodb-debezium-entrypoint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just being picky. You can save this sentence using --chmod in the previous one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I just left two minor comments,
tries=30 | ||
while true; do | ||
if ! { [ -s "$PIDFILE" ] && ps "$(cat "$PIDFILE")" > /dev/null 2>&1; }; then | ||
echo "❌ mongod process did not stay running. Check logs for errors." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that emoji work on all terminals, CI etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably not
mongod --fork --dbpath "$DB_PATH" --port "$PORT" --logpath "$LOG_PATH" --pidfilepath "$PIDFILE" | ||
|
||
echo "=> Waiting for MongoDB to start..." | ||
tries=30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be configurabe, I can imagine that CI might need longer time.
closes https://issues.redhat.com/browse/DBZ-9516
Mongodb Custom image