Initial support for javascript callbacks for node >= 0.12 running on linux #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No9
added a commit
that referenced
this pull request
Jan 29, 2016
Initial support for javascript callbacks for node >= 0.12 running on linux
|
This breaks with node.js 0.10: |
|
Thanks @papandreou |
|
Makes sense, I'll take a look at implementing this in a NAN friendly way. |
|
a Nan friendly way: // Globals:
static bool has_user_callback = false;
static Nan::Persistent<v8::Function> user_defined_callback{};
// add to RegisterHandler:
if (info.Length() > 1) {
user_defined_callback.Reset(info[1].As<v8::Function>());
has_user_callback = true;
}
// add to SEGFAULT_HANDLER:
if(has_user_callback) {
Isolate* isolate = Isolate::GetCurrent();
Local<Function> cb = New(user_defined_callback);
const unsigned int argc = 3;
Local<Value> argv[argc] ={String::NewFromUtf8(isolate, "hello world"),
String::NewFromUtf8(isolate, "hello world"),
String::NewFromUtf8(isolate, "hello world")
};
cb->Call(Null(isolate), argc, argv);
has_user_callback = false;
user_defined_callback.Reset(); // destroy persistent object
}the bool has_user_callback is probably already integrated in Nan::Persistent and could be replaced (if you're striving for elegance). for the windows part of this issue i wrote some stuff in #38 tested with node 6.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #11 and updated to support newer versions of Node.js as well as proper handling of cross-thread callbacks.
I haven't had the time to look into what it would take to get it fully implemented for Windows, it would need a dependency or alternative for pthreads and a way to get the stack array from StackWalker.
Regardless, it should still build and run the same as always on Windows, just without callback support.