Skip to content

Get a stack trace on Mac OS X as well #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Feb 17, 2014

Building upon #11. Also gets stack trace on Mac OS X.

@paazmaya
Copy link

#10 seems to have added some of the same stuff, such as CFLAGS.

Perhaps this PR could be updated to match against current master and thus be merged?

@mitar
Copy link
Contributor Author

mitar commented Jul 24, 2014

You can just cherry-pick send commit.

@paazmaya
Copy link

Sure I can...., but can the maintainer of this repository?

@mitar
Copy link
Contributor Author

mitar commented Sep 3, 2014

seems to have added some of the same stuff, such as CFLAGS.

It is not true that it has the same. I looked into it and I added additional flags like debug symbols so that stack trace is better.

@mitar
Copy link
Contributor Author

mitar commented Sep 3, 2014

I updated the pull request to the latest master. It is clearer now.

@ddopson
Copy link
Owner

ddopson commented Sep 16, 2015

Is this patch up to date? It seems to have conflicts.

I don't have node installed on my machine, so I'm really really bad about dealing with patches. I feel TERRIBLE about that and I've always hated submitting patches into the void and not getting a response.

If you (or anyone else) still cares about this patch and wants to drive it, I'll work with you to get it in. If I don't respond, ping me with (my username) at gmail. The notification system for Github leaves a lot to be desired.

@No9
Copy link
Collaborator

No9 commented Sep 25, 2015

OK so I think this is resolved as part of this conversation
#29
So I am going to close this off.

@No9 No9 closed this Sep 25, 2015
@mitar
Copy link
Contributor Author

mitar commented Sep 28, 2015

No, this is much bigger pull request than what #29 was. #29 seems to be just about compiling, but here pull request uses some other ways to get symbols for the stack trace available on the Mac OS X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants