Multistage #221
Draft
Multistage #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 94.96% 95.50% +0.53%
==========================================
Files 9 9
Lines 1113 1179 +66
Branches 231 253 +22
==========================================
+ Hits 1057 1126 +69
+ Misses 42 39 -3
Partials 14 14 ☔ View full report in Codecov by Sentry. |
dcermak
force-pushed
the
multistage
branch
9 times, most recently
from
bdeb383 to
9cf6e5d
Compare
dcermak
force-pushed
the
multistage
branch
2 times, most recently
from
f3378bf to
aebac9d
Compare
grisu48
reviewed
Sep 12, 2024
Collaborator
grisu48
left a comment
grisu48
left a comment
There was a problem hiding this comment.
Bigger PR, but so far it makes sense. LGTM.
| via ``--network=host``. | ||
|
|
||
| The :py:meth:`~pytest_container.container.ContainerBaseABC.prepare_container` | ||
| The :py:meth:`~pytest_container.container._ContainerPrepareABC.prepare_container` |
Collaborator
There was a problem hiding this comment.
Since _ContainerPrepareABC is just an abstract internal class, I wonder if it makes much sense to mention it in a usage document, but I guess this is more of a style question.
| for name, ctr in self.containers.items(): | ||
| if isinstance(ctr, str): | ||
| warnings.warn( | ||
| UserWarning( |
Collaborator
There was a problem hiding this comment.
Neat warning and code block, me likes!
grisu48
previously approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #149