Added support to filter nested fields #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42 replacement for this PR
@albertisfu here is an alternative approach where we do allow each serializer the ability to filter itself instead of orchestrating the filtering from the parent.
Does this approach work for your use-case? You can see that this cuts down on the logic spread throughout the fields method, and contains the hard work of finding the fields to filter / omit in some helper functions - I'm sure these could be simplified further - they are just gpt code. (for example I don't like
while
statements as a rule)