Remove click<8.1.8 version limit #1240
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great to have some bisecting done to narrow down the problem. I took a look at the most likely parts of the |
|
Reproducing it locally, narrowed it down to 299efb82e1a3d34d870129dc0c677c6efb42d811 but haven't investigated more as I'm unfamiliar with all this machinery lol. |
|
Ah, that's very helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clickwas set to<8.1.8in bb18b0c in #1200 due to this test run failing - I'm just wondering if it's still failing on more recent versions, so I'm posting this as a draft to run the tests. I tried and failed to reproduce it locally.Checklist
changelog.md.AUTHORSfile (or it's already there).