WIP: Improve buffer switching #409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, because the behavior changed. Before adjusting them, I'd like to get feedback on this. |
|
Since this would be a change with big impact, I really need to play with it first. I don't have time for the next few days, so it might still take a while. |
blueyed
force-pushed
the
improve-buffer-switching
branch
from
f3d3b89 to
04c2dde
Compare
|
Sure. |
|
Since we have started the discussion in #408, I will continue it there. |
It should use the same code path/logic. Apart from that, `:tab drop` is also available in non-GUI Vim.
This adds `jedi_vim.edit_buffer`, factored out of `new_buffer`, and `goto` uses it. Ref: davidhalter#408
It was passed around, but never used really. The only place would have been `:Pyimport`, but that command definition has `-nargs=1`.
This will only write the buffer file, if the buffer has changed.
blueyed
force-pushed
the
improve-buffer-switching
branch
from
04c2dde to
a096b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on suggestions and discussion in #408