Add new HEIC magic numbers for 10 bit images #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone, we know that this project is in a maintenance state, but we lack the resources to migrate to the recommended
vipsgenlibrary and we need to makegovipswork with 10 bit HEIC images from Apple devices, which have a different magic number, see here:strukturag/libheif#83 (comment)
Since they are supported by libheif it should be a no-brainer to add them:
https://github.com/strukturag/libheif/blob/master/go/heif/heif.go#L1508-L1517
It was tested internally with a 10 bit image successfully.