Use repo secrets for aws credentials #186
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #186 +/- ##
===========================================
+ Coverage 61.31% 64.15% +2.83%
===========================================
Files 54 56 +2
Lines 16339 16414 +75
Branches 2950 2956 +6
===========================================
+ Hits 10018 10530 +512
+ Misses 6191 5754 -437
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mlathara
force-pushed
the
aws_secret_update
branch
3 times, most recently
from
9f57798 to
3d5686a
Compare
| brew list openssl@${{matrix.openssl-version}} &>/dev/null || brew install openssl@${{matrix.openssl-version}} | ||
| brew list ossp-uuid &>/dev/null || brew install ossp-uuid | ||
| brew list catch2 &>/dev/null || brew install catch2 | ||
| # taken from https://github.com/actions/runner-images/pull/12791/files |
There was a problem hiding this comment.
Yikes, always had issues with cmake and macOS...
| # Install ZStd | ||
| sudo apt-get install -y zstd && | ||
| export ENABLE_ZSTD=1 | ||
| #export ENABLE_ZSTD=1 |
There was a problem hiding this comment.
Is zstd not working with ubuntu 22.0.4?
There was a problem hiding this comment.
I wish I knew! I'm sorta fumbling in the dark here because the CI tests are failing... :(
There was a problem hiding this comment.
This gets even weirder. I didn't notice this earlier, but the github actions build is going through for the build that is triggered by the PR, but not for the build triggered by the push.
But those should be the same, right?? I'm very confused. I see this in the actions
push:
#branches: [ master, develop ]
paths-ignore:
Maybe I should uncomment that branches part so that the push build only happens for master and develop?
mlathara
force-pushed
the
aws_secret_update
branch
from
ee8390c to
61fcd60
Compare
Created a user with minimal privileges to allow for AWS tests. Minor changes to github actions to use the new user's credentials. The ubuntu 20.04 tests still don't run of course since that's been deprecated...could remove those or try to bump those to 24.04. For now, I didn't want to tackle whatever inevitable incompatibility that'll bring.