Exclude feeder from service time #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay I just had a chance to look at this. Do we have any tests for these changes? |
bradfordcp
reviewed
Oct 29, 2018
| import scala.sys.process._ | ||
|
|
||
| val gatlingVersion = "2.3.0" | ||
| val gatlingVersion = "2.3.1" |
There was a problem hiding this comment.
Should this be part of a separate issue / PR?
bradfordcp
reviewed
Oct 29, 2018
|
|
||
| stmt.onFailure(err => { | ||
| val responseTime: ResponseTime = responseTimeBuilder.build() | ||
| val responseTime = new ServiceTime(0, 0) |
There was a problem hiding this comment.
Would it be clearer to name this serviceTime instead of responseTime?
This would also require a change to line 71:
statsEngine.logResponse(session, name, serviceTime.toGatlingResponseTimings, KO, None,
Some(s"$tagString - Preparing: ${err.take(50)}"), List(responseTime.latencyIn(MICROSECONDS), "PRE", logUuid)) Some(s"$tagString - Preparing: ${err.take(50)}")
but to me that seems a bit clearer. We are converting a ServiceTime to a ResponseTime. Thoughts?
bradfordcp
reviewed
Oct 29, 2018
|
|
||
| stmt.onFailure(err => { | ||
| val responseTime = responseTimeBuilder.build() | ||
| val responseTime = new ServiceTime(0, 0) |
There was a problem hiding this comment.
Same comments as CqlRequestAction regarding responseTime vs serviceTime.
bradfordcp
reviewed
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the feeder generation time is not included in the measured latency when the plugin is configured to measure service time. It also adds a log that confirms which time is being measured for a given scenario.