-
Notifications
You must be signed in to change notification settings - Fork 87
[RAPTOR-13896] force reconciling deps for all the envs except genai-agents #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The Needs Review labels were added based on the following file changes. Team @datarobot/buzok (#buzok) was assigned because of changes in files:public_dropin_environments/python311_genai/env_info.json public_dropin_environments/python311_genai/requirements.txt Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_pmml/env_info.json public_dropin_environments/python3_pmml/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt Team @datarobot/genai-systems (#genai-systems) was assigned because of changes in files:public_dropin_environments/java_codegen/env_info.json public_dropin_environments/java_codegen/requirements.txt public_dropin_environments/python311/env_info.json public_dropin_environments/python311/requirements.txt public_dropin_environments/python3_keras/env_info.json public_dropin_environments/python3_keras/requirements.txt public_dropin_environments/python3_onnx/env_info.json public_dropin_environments/python3_onnx/requirements.txt public_dropin_environments/python3_pmml/env_info.json public_dropin_environments/python3_pmml/requirements.txt public_dropin_environments/python3_pytorch/env_info.json public_dropin_environments/python3_pytorch/requirements.txt public_dropin_environments/python3_sklearn/env_info.json public_dropin_environments/python3_sklearn/requirements.txt public_dropin_environments/python3_xgboost/env_info.json public_dropin_environments/python3_xgboost/requirements.txt public_dropin_environments/r_lang/env_info.json public_dropin_environments/r_lang/requirements.txt public_dropin_gpu_environments/vllm/env_info.json public_dropin_gpu_environments/vllm/requirements.txt If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file. |
cdd5ac9
to
1bbd934
Compare
c0b0b1f
to
9219fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM for Predictive AI.
I also reviewed a PR from dependabot, bumping just protobuf in just the xgboost drop-in environment. That PR #1521 would conflict with this one -- but yours is essentially a superset of that one. Just FYI -- if you can get this green and merged before that one goes in, I think that's OK.
datarobot==3.7.1 | ||
datarobot-drum==1.16.17 | ||
datarobot-mlops==11.1.0a3 | ||
datarobot-mlops==11.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a downgrade, 11.1 to 11.0 -- is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like pip-compile always take the latest released version, ignoring pre-releases.
Pinning it in the requirements.in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, it was a pre-release. I could see it either way, then. Do you know, is the stable release 11.1 of datarobot-mlops
coming soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to figure out, but no luck yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes to python311_genai env so GenAI review not necessary
76263ba
to
7eb61bb
Compare
e79a8b0
to
8185a58
Compare
This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.
Summary
Force reconciling deps for all the envs except genai-agents.
I think worth doing before release/
Rationale