-
Notifications
You must be signed in to change notification settings - Fork 22
Add persistent per-item access tokens that can be used in QR codes #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ml-evs
wants to merge
8
commits into
main
Choose a base branch
from
ml-evs/add-access-tokens-to-qr-codes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
Project |
datalab
|
Branch Review |
ml-evs/add-access-tokens-to-qr-codes
|
Run status |
|
Run duration | 07m 06s |
Commit |
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
336
|
View all changes introduced in this branch ↗︎ |
As discussed, feel free to deploy and ping me once it's ready for testing. When QR codes are printed on curvy/flexible surfaces, they're harder to read - I can test how small we can print the QR code to still be useful. |
0c2d9cb
to
9ac73a6
Compare
Small pytest fix Small pytest fix Small pytest fix Small pytest fix Small pytest fix
5ffbe91
to
920beb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initiates the work on allowing QR codes to be generated that are
accessible by anyone who has printed one out, requested by @PeterKraus in #1053.
It does this by adding a
/items/<refcode>/issue-access-token
endpoint, which stores a token in thedatabase that can be used to access that refcode without login. A corresponding
admin endpoint for invalidating the token is added, in case of nefarious use.
Outstanding questions:
think this could be a future PR.
uuid.uuid1()
for the token generatiion (and storing a sha-512 hash of it in the database), but we might need to reduce the entropy a bit so that it fits into a printable QR.