-
Notifications
You must be signed in to change notification settings - Fork 22
Upgrade to Bootstrap v5 #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to Bootstrap v5 #1028
Conversation
0b62df8
to
5b3c114
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 65 65
Lines 4300 4300
=======================================
Hits 3057 3057
Misses 1243 1243
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bc/update-bootstrap5
|
Run status |
|
Run duration | 08m 45s |
Commit |
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
504
|
View all changes introduced in this branch ↗︎ |
dfc981f
to
a09a084
Compare
48d928f
to
70ae51b
Compare
f4630f0
to
05f278f
Compare
d4dba9e
to
7a936d1
Compare
7a936d1
to
3c10d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've built and played around with the new version and only have a few minor comments of mine (and we can go through yours) -- just a comment below about the deps!
d18c840
to
38a406c
Compare
Everything works! 🎉 I still need to refactor the e2e tests a bit (I added a lot of functions) and clean things up, and then the PR will be ready. |
462dad0
to
2261bd1
Compare
2261bd1
to
7195311
Compare
Router links underlined only when selected Router links underlined only when selected
57d37aa
to
ca9a03e
Compare
max-length for FormattedItemName in SynthesisInformation
d0b2edf
to
7fc6c35
Compare
I've made most of the changes asked, whenever you have time to take a look @ml-evs . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @BenjaminCharmes, this is looking really nice from my side! I'm going to approve this now, but we should hold off merging it until the 0.5.3 release is out. Then this can be the first PR merged for the 0.6.0 series.
Closes #32:
<button />
class used to closeModal
ml-2
(doesn't exist in Bootstrap v5) bygap-2
(d-flex) forDynamicDataTableButtons
(could also useme-2
from bootstrap instead) (Bootstrap left and right replaced by start and end)color: black
to FormattedItemName becausebadge light
display text in white nowCloses #620:
Cypress:
cy.wait()
that could (should?) be removed (I haven't removed them, waiting feedback).