Skip to content

Conversation

Pierlou
Copy link
Contributor

@Pierlou Pierlou commented Jan 8, 2025

⚠️ Do not merge before we're sure that sorting resources is not the cause of resource duplication

@Pierlou Pierlou requested a review from hacherix January 8, 2025 11:08
@Pierlou Pierlou marked this pull request as draft January 8, 2025 14:39
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what would go wrong, it does seem to makes sense

Comment on lines +565 to +568
if len(sorted_ids) != len(resources):
raise ValueError("The sorted list has a different number of elements, aborting")
if len(sorted_ids) != len(set(r["id"] for r in sorted_ids)):
raise ValueError("An id has been duplicated in the sort process", resources, "vs", sorted_ids)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants