fix(components): imports and requests #746
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
maudetes
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Should we remove illustrations from public/illustrations/?
There was a problem hiding this comment.
No, we want our illustrations in public for cdata. Only the illustrations used in the components should be duplicated.
If we want to save space, we can only move the wanted file in the assets folder and not the whole folder.
There was a problem hiding this comment.
Ok, maybe I'm being naive, but could we symlink the folders?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.