feat: datasets access_type and access_audiences
#688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaudDauce
changed the title
access_type and access_audiences
ThibaudDauce
requested review from
maudetes and
nicolaskempf57
as code owners
ThibaudDauce
changed the title
access_type and access_audiencesaccess_type and access_audiences
| {{ $t('Ces données ne sont accessibles que sur habilitation') }} | ||
| </p> | ||
| <p | ||
| v-if="dataset.access_type_reason" |
There was a problem hiding this comment.
Do we want to show the reason category if we only have it ?
There was a problem hiding this comment.
After discussing it with @agarrone, it seems that we also want to show the reason category when we aren't in the other case
There was a problem hiding this comment.
The reason category and the free text reason will be really similar in lot of cases I think from harvesting. We can chat about it…
There was a problem hiding this comment.
The issue is that if we only have a category, it won't be shown. I agree with you, we shouldn't show both at the same time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.