Skip to content

Conversation

@wyattscarpenter
Copy link
Contributor

The capital letter version from typing has been deprecated since Python 3.9 https://docs.python.org/3/library/typing.html#typing.Dict

What type of PR is this?

  • Refactor

How is this tested?

Type check in the CI

The capital letter alias from typing has been deprecated since Python 3.9 https://docs.python.org/3/library/typing.html#typing.Dict

Signed-off-by: wyattscarpenter <[email protected]>
@amarvin
Copy link

amarvin commented Dec 4, 2025

This package is supposed to still support Python 3.8 though.

@wyattscarpenter
Copy link
Contributor Author

wyattscarpenter commented Dec 5, 2025

@amarvin Thanks for mentioning! That claim conflicts with the readme. https://github.com/databricks/databricks-sql-python?tab=readme-ov-file#requirements

Requirements
Python 3.9 or above is required.

However, it does seem to match the information given on https://pypi.org/project/databricks-sql-connector/, which is a release from today.

Requires: Python <4.0.0, >=3.8.0

I'm happy to draft this PR if we really do support 3.8 here. Easy to change the readme if so... or change the other requirement if not.

Also, no unit tests run on 3.8. If 3.8 is supported, they probably should.

Also, while someone is looking into it, it's arguably wrong to specify Python <4.0.0. There's a whole thread about it somewhere. You can just leave that off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants