Skip to content

SEA volume operations fix: assign manifest.is_volume_operation to is_staging_operation in ExecuteResponse #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sea-migration
Choose a base branch
from

Conversation

varun-edachali-dbx
Copy link
Collaborator

What type of PR is this?

  • Bug Fix

Description

Earlier, is_staging_operation in ExecuteResponse was hardcoded to False for the SEA client.
Now, we assign it to is_volume_operation from the ResultManifest.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually - tested against related e2e tests in the existing test suite after setting use_sea to True in the connection params.
  • N/A

Related Tickets & Documents

N/A

@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review June 20, 2025 03:23
@varun-edachali-dbx varun-edachali-dbx changed the title SEA volume operations fix: assign manifest.is_volume_operation to is_staging_operation in ResultManifest model SEA volume operations fix: assign manifest.is_volume_operation to is_staging_operation from result manifest Jun 20, 2025
@varun-edachali-dbx varun-edachali-dbx changed the title SEA volume operations fix: assign manifest.is_volume_operation to is_staging_operation from result manifest SEA volume operations fix: assign manifest.is_volume_operation to is_staging_operation in ExecuteResponse Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants