Remove unused flags when --json is force and force json for budget-policy #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
pietern,
shreyas-goenka,
denik and
anton-107
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Apr 9, 2025
| @@ -262,7 +263,7 @@ func new{{.PascalName}}() *cobra.Command { | |||
| return err | |||
| } | |||
| } | |||
| }{{end}}{{ if .MustUseJson }}else { | |||
There was a problem hiding this comment.
Can we remove .MustUseJson now?
There was a problem hiding this comment.
We still use it above to define jsonOnly variable
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
changed the title
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove unused flags when --json is force and force json for budget-policy
Why
Some update commands which have complex request body (like budget-policy) needs to be used with a JSON input and not command line flags because it can lead to the errors when user unintentionally forget to specify some body input and the resources gets update to empty values (see all policy related commands for example)
Tests
Manually verified