FIX: Wrap torch.argsort to set stable=True by default #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR wraps torch.argsort to set stable=True by default, aligning it with the array API specification and matching the behavior of the existing sort wrapper.
- Adds a new
argsortfunction wrapper that defaultsstableparameter toTrue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Remove the empty line with trailing whitespace inside the function body. This line serves no purpose and should be deleted. Co-authored-by: Copilot <[email protected]>
cakedev0
commented
Oct 19, 2025
| from typing import Literal | ||
|
|
||
| import torch | ||
| import torch # noqa: F401 |
There was a problem hiding this comment.
Unrelated to this PR, but CI was failing without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is in the title.
Fixes #354