Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

@Plonq
Copy link

@Plonq Plonq commented May 26, 2024

To be honest I'm not sure whether this is the correct way to fix this, but it seems that #101 is caused by cd52f9f which moved the keyboard event handling to use Event::DeviceEvent instead of Event::WindowEvent -> WindowEvent::KeyboardInput. In my testing Event::DeviceEvent is not fired when pressing keys (on macOS). This doesn't revert the above commit, it merely moves the code to use WindowEvent::KeyboardInput instead.

Fixes #101

@Plonq
Copy link
Author

Plonq commented May 26, 2024

Note: doc check seems to be failing due to pre-existing typo

@darthdeus
Copy link
Owner

Thanks for this, I'll take a look soon 👀

gavinmorrow added a commit to gavinmorrow/comfy that referenced this pull request Jun 28, 2024
@evanmcc
Copy link

evanmcc commented Aug 21, 2024

is there a new release coming soon that might incorporate this fix?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

is_key_down and is_key_pressed not working in 0.4.0 on macOS

3 participants