-
Notifications
You must be signed in to change notification settings - Fork 6
Add support for Cloud Tasks #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I made a few review comments, but don't have enough context to say whether this is an API we want (or what it should look like).
cc'ing @sigurdm and the @dart-lang/dart-pub-team generally for thoughts.
@@ -0,0 +1,68 @@ | |||
/// This library provides a low-level API for accessing Google's Cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the std 3-line copyright header here? For 2025.
@@ -0,0 +1,47 @@ | |||
import 'dart:convert'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3-line copyright header
@@ -0,0 +1,65 @@ | |||
import 'dart:convert'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyright header
Adds minimal Cloud Tasks support (creating a task with an http request).
I'm not sure if this is built out enough to warrant merging, and I imagine documentation updates would be required as well. lmk what you think!
Contribution guidelines:
dart format
.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.