Skip to content

Conversation

shanedsnyder
Copy link

Building off suggestion from @wkliao in #844

These changes allow us to build runtime and util portions of Darshan with different options (i.e., util with AutoPerf, runtime without AutoPerf) and test each independently with make distcheck. It seems to work fine for me locally, but will see what the CI says.

@github-actions github-actions bot added the CI continuous integration label Nov 22, 2022
Copy link
Contributor

@carns carns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My only minor suggestion (if its possible) would be to have the install actions print something like "RUNNING make...", "RUNNING make distcheck..." etc. because the output from those steps is really long. It might be helpful to have some markers in there to make it easier to see what command its when when there is a problem.

@tylerjereddy
Copy link
Collaborator

It might be helpful to have some markers in there to make it easier to see what command its when when there is a problem.

You could split them out into separate steps in the GitHub actions script/config so that they get sequestered output in the online interface.

This won't be perfect syntax, but something like this:

- name: Run make for runtime
  run: make --add-more
  working-directory: ./temp-fixme
- name: Run distcheck for runtime
  run: make distcheck --add-more
  working-directory: ./temp-fixme
etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants