Skip to content

Change mmap I/O default mode to enable #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Change mmap I/O default mode to enable #1055

merged 1 commit into from
Jul 30, 2025

Conversation

wkliao
Copy link
Collaborator

@wkliao wkliao commented Jul 22, 2025

Test CI to see if making mmap I/O the default.

@wkliao wkliao requested a review from carns July 22, 2025 14:01
carns
carns approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@carns carns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it ran just fine. I'm in favor of merging this whenever you are comfortable with it. Given usage we see these days it should be the default, and we should switch it well ahead of the next point release.

@wkliao
Copy link
Collaborator Author

wkliao commented Jul 30, 2025

OK. Once merged, the next step is to rebase PR #1053 to see how it works for all CI.

@wkliao wkliao merged commit 3811692 into darshan-hpc:main Jul 30, 2025
6 checks passed
@wkliao wkliao deleted the mmap_default branch August 4, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carns carns carns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkliao @carns