Skip to content

Conversation

gustavo-sdo
Copy link

No description provided.

@darklow
Copy link
Owner

darklow commented Aug 18, 2016

Thanks for PR.
Is this compatible with older Django versions like 1.4, 1.5 etc?

@gustavo-sdo
Copy link
Author

@darklow
Using Django 1.10.
Not tested with earlier versions.

Print the previous version

@darklow
Copy link
Owner

darklow commented Aug 18, 2016

In order to accept your PR, you will need to implement fallback to older versions using specific version check, similar like here:

{% if '1.9'|django_version_lt %}

Using any if version check functions with _lt, _lte, _gt or _gte suffixes from suit_tags:
https://github.com/darklow/django-suit/blob/develop/suit/templatetags/suit_tags.py#L104

@gustavo-sdo
Copy link
Author

I understand @darklow.
There are many Django-suit users using older versions of Django?

Or is there some other special reason to maintain support?

@darklow
Copy link
Owner

darklow commented Aug 18, 2016

Thank you for making changes. Until v1.x branch is discontinued in favour of upcoming v2-dev (which I encourage to start using already) this branch promises by docs to support all Django versions from 1.4-1.10 and while keeping compatibility doesn't require too much effort I intend to keep it that way.
As far as I know lot of users still use 1.6 to 1.8 (long term support) versions.

@gustavo-sdo
Copy link
Author

Certainly @darklow,

As more people began to use v2 faster the project will be complete and structured.

By the way, something that I find very interesting would be the option of keeping the vertical menu on the django-suit v2 (I've read some reviews about it, but I would leave my opinion 😄).

@darklow
Copy link
Owner

darklow commented Aug 18, 2016

@gustavosdo I see many feature requests about vertical nav for v2, therefore I will implement vertical menu too similar as v1.

@kliyes
Copy link

kliyes commented May 17, 2017

@darklow will this PR be merged? I'm using django1.10.7 and faced the same problem.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants