-
Notifications
You must be signed in to change notification settings - Fork 23
get stress table output from OVERVIEW.OUT #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
corrected a small mistake where i had if condition wrong.
Hi! thanks for your contribution. I'm reviewing the request and the changes in the code is causing some of the tests to fail. I'll modify what is causing the issue and then I'll merge it. Also, instead of saving the output in |
corrected a small mistake where i had if condition wrong.
After reviewing I made a couple changes. It seems Perennial forages don't generate the overview file, that was causing some issues. Now, I'm adding the stress into a new DSSAT.stress_table attribute. The OVERVIEW file is saved in the output attribute as the lines of the raw file. However, I see that there is some problems with the stress table, it seems that the Dev stage column is not being created is it's supposed to be. You can check what I mean in one of the tests, maybe the Maize test is the best example to work with. I just pushed the changes I made, and as soon as we make sure the new function correctly creates the stress tables for all crops, then I'll proceed to merge and update the PyPI package. Thanks again for your contribution. |
Hi, Thank you for the library again. Your changes makes more sense as it will be easier to understand than naming it as |
added a function to get stage-wise stress output from OVERVIEW.OUT. The function handles only the first run. Will add functionality to create table for all runs with run number as index. Please make changes if anything is needed. thanks for the package.