-
Notifications
You must be signed in to change notification settings - Fork 218
Migrate PubSub removing flaky test #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@artur-ciocanu @cicoyle @salaboy Trying to move the following test to use Testcontainers I got a problem. java-sdk/sdk-tests/src/test/java/io/dapr/it/pubsub/http/PubSubIT.java Lines 571 to 572 in 3a8fd61
When running the test from
I have 1 message with the first message containing 10 statuses. But using in-memory (Testcontainers) I have 10 messages and each one with 1 statuses. I would like to know if the |
@@ -0,0 +1,11 @@ | |||
package io.dapr.it.testcontainers.pubsub.http; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the header to all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, tomorrow early I will do it
@mcruzdev I will try to review ASAP, but could you please check why the ITs are failing? |
It is another mapped flaky test |
Signed-off-by: Matheus Cruz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
============================================
+ Coverage 76.91% 78.34% +1.42%
- Complexity 1592 1847 +255
============================================
Files 145 226 +81
Lines 4843 5707 +864
Branches 562 601 +39
============================================
+ Hits 3725 4471 +746
- Misses 821 916 +95
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Use testcontainers for PubSub tests.
The main goal is to remove the following flaky test https://github.com/dapr/java-sdk/actions/runs/13773009141/job/38515768267#step:19:13432.
Closes one of the flaky test links related on the #1258 issue.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: