Adding Support for Suspend / Resume Workflows #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salaboy
force-pushed
the
1402-suspend-resume
branch
2 times, most recently
from
1c96955 to
c879104
Compare
|
While waiting for CI I am adding docs and examples, do not merge yet. |
salaboy
force-pushed
the
1402-suspend-resume
branch
2 times, most recently
from
f285dc5 to
100e8b4
Compare
siri-varma
reviewed
Jun 6, 2025
.../workflows/src/main/java/io/dapr/springboot/examples/wfp/WorkflowPatternsRestController.java
Show resolved
Hide resolved
siri-varma
reviewed
Jun 6, 2025
.../workflows/src/main/java/io/dapr/springboot/examples/wfp/WorkflowPatternsRestController.java
Show resolved
Hide resolved
siri-varma
reviewed
Jun 6, 2025
.../workflows/src/main/java/io/dapr/springboot/examples/wfp/WorkflowPatternsRestController.java
Show resolved
Hide resolved
siri-varma
reviewed
Jun 6, 2025
examples/src/main/java/io/dapr/examples/workflows/suspendresume/DemoSuspendResumeClient.java
Show resolved
Hide resolved
siri-varma
reviewed
Jun 6, 2025
siri-varma
reviewed
Jun 6, 2025
examples/src/main/java/io/dapr/examples/workflows/suspendresume/DemoSuspendResumeClient.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/dapr/examples/workflows/suspendresume/DemoSuspendResumeWorker.java
Outdated
Show resolved
Hide resolved
...rkflows/src/main/java/io/dapr/springboot/examples/wfp/suspendresume/PerformTaskActivity.java
Outdated
Show resolved
Hide resolved
salaboy
force-pushed
the
1402-suspend-resume
branch
from
e3a9e25 to
7917774
Compare
|
all comments addressed @dapr/maintainers-java-sdk |
|
LGTM |
salaboy
force-pushed
the
1402-suspend-resume
branch
from
b943f9b to
18cc693
Compare
cicoyle
reviewed
Jun 9, 2025
examples/src/main/java/io/dapr/examples/OpenTelemetryConfig.java
Outdated
Show resolved
Hide resolved
salaboy
force-pushed
the
1402-suspend-resume
branch
from
18cc693 to
078bb0d
Compare
cicoyle
reviewed
Jun 9, 2025
salaboy
force-pushed
the
1402-suspend-resume
branch
2 times, most recently
from
5a03d1d to
3345b58
Compare
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
Signed-off-by: salaboy <[email protected]>
salaboy
force-pushed
the
1402-suspend-resume
branch
from
1a2f7bf to
646268d
Compare
|
all green @dapr/maintainers-java-sdk |
cicoyle
approved these changes
Jun 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1405 +/- ##
============================================
+ Coverage 76.91% 78.45% +1.53%
- Complexity 1592 1858 +266
============================================
Files 145 228 +83
Lines 4843 5760 +917
Branches 562 601 +39
============================================
+ Hits 3725 4519 +794
- Misses 821 921 +100
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cicoyle
added a commit
to cicoyle/java-sdk
that referenced
this pull request
Jun 11, 2025
* adding IT test Signed-off-by: salaboy <[email protected]> * adding initial version of suspend/resume example Signed-off-by: salaboy <[email protected]> * updating README Signed-off-by: salaboy <[email protected]> * Update README.md Signed-off-by: salaboy <[email protected]> * following Javi's suggestion Signed-off-by: salaboy <[email protected]> * fixing wrong year in headers Signed-off-by: salaboy <[email protected]> * fixing paths in one more README.md file Signed-off-by: salaboy <[email protected]> * adding output validation Signed-off-by: salaboy <[email protected]> * adding missing port Signed-off-by: salaboy <[email protected]> * fixing check conditions Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Co-authored-by: Cassie Coyle <[email protected]>
cicoyle
added a commit
that referenced
this pull request
Jun 11, 2025
* Compensation example for Workflows (#1333) * add basic compensation example for wf Signed-off-by: Cassandra Coyle <[email protected]> * update commands to run + wf id Signed-off-by: Cassandra Coyle <[email protected]> * update readme + add mechanical markdown Signed-off-by: Cassandra Coyle <[email protected]> * fix import Signed-off-by: Cassandra Coyle <[email protected]> * fix mechanical markdown + add how to test it locally Signed-off-by: Cassandra Coyle <[email protected]> * move compensation example readme to workflows readme Signed-off-by: Cassandra Coyle <[email protected]> * Update BookCarActivity.java Signed-off-by: artur-ciocanu <[email protected]> * Update BookFlightActivity.java Signed-off-by: artur-ciocanu <[email protected]> * Update BookHotelActivity.java Signed-off-by: artur-ciocanu <[email protected]> * Update BookTripClient.java Signed-off-by: artur-ciocanu <[email protected]> * Update BookTripWorker.java Signed-off-by: artur-ciocanu <[email protected]> * Update BookTripWorkflow.java Signed-off-by: artur-ciocanu <[email protected]> * Update CancelCarActivity.java Signed-off-by: artur-ciocanu <[email protected]> * Update CancelFlightActivity.java Signed-off-by: artur-ciocanu <[email protected]> * Update CancelHotelActivity.java Signed-off-by: artur-ciocanu <[email protected]> * add retry IT tests and catch TaskFailedException Signed-off-by: Cassandra Coyle <[email protected]> * add test for no compensation if successful and assert attempts Signed-off-by: Cassandra Coyle <[email protected]> * update mechanical markdown Signed-off-by: Cassandra Coyle <[email protected]> * add back pubsub... but this should be removed long term Signed-off-by: Cassandra Coyle <[email protected]> * try adding waitforsidecar Signed-off-by: Cassandra Coyle <[email protected]> * rm tests from examples pr Signed-off-by: Cassandra Coyle <[email protected]> * reset unintended changes Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> * Adding Support for Suspend / Resume Workflows (#1405) * adding IT test Signed-off-by: salaboy <[email protected]> * adding initial version of suspend/resume example Signed-off-by: salaboy <[email protected]> * updating README Signed-off-by: salaboy <[email protected]> * Update README.md Signed-off-by: salaboy <[email protected]> * following Javi's suggestion Signed-off-by: salaboy <[email protected]> * fixing wrong year in headers Signed-off-by: salaboy <[email protected]> * fixing paths in one more README.md file Signed-off-by: salaboy <[email protected]> * adding output validation Signed-off-by: salaboy <[email protected]> * adding missing port Signed-off-by: salaboy <[email protected]> * fixing check conditions Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: salaboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for suspend/resume workflows to the Java SDK.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1402
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: