common: expand the sds.at_create CTL to also cover pmemobj_open()

[janekmi]

https://daosio.atlassian.net/browse/DAOS-17449

---

This change is 

[janekmi]

Preview - pool with disabled SDS (MD-on-SSD-like)

$ diff log_create_org.txt log_create_mod.txt 
9a10
> <libpmemobj>: <1> [ctl_sds.c:36 ctl__at_create_write] PMEM feature disabled: SDS_at_create=0

$ diff log_open_org.txt log_open_mod.txt 
9a10
> <libpmemobj>: <1> [ctl_sds.c:36 ctl__at_create_write] PMEM feature disabled: SDS_at_create=0
11,12c12
< <libpmemobj>: <1> [obj.c:1090 pmemobj_createU] cannot create pool or pool set
< <libpmemobj>: <2> [set.c:2794 util_replica_check] Possible silent data corruption. The unsafe shutdown detection (SDS) is not supported in the pool: /tmp/myfile
---
> <libpmemobj>: <1> [obj.c:1096 pmemobj_createU] cannot create pool or pool set

Files

log_create_org.txt
log_create_mod.txt
log_open_org.txt
log_open_mod.txt

[janekmi]

Preview - pool with enabled SDS (MD-on-PMEM-like)

Excuse me for using an SDS-enabled pool on non-PMEM. 😆 Please ignore it. The key bit is how modified PMEMOBJ behaves in case it will open a SDS-enabled pool will

$ diff log_open_sds_enabled_pool_org.txt log_open_sds_enabled_pool_mod.txt 
9a10
> <libpmemobj>: <1> [ctl_sds.c:37 ctl__at_create_write] PMEM feature disabled: SDS_at_create=0
12,13c13,14
< <libpmemobj>: <1> [usc_ndctl.c:54 pmem2_source_device_usc] Unsafe shutdown count is not supported for this source
< <libpmemobj>: <1> [shutdown_state.c:80 shutdown_state_add_part] cannot read unsafe shutdown count for 4
---
> <libpmemobj>: <1> [pool_hdr.c:173 util_feature_check] unsafe to continue due to unknown incompat features: 0x4
> <libpmemobj>: <1> [set.c:2804 util_replica_check] header check failed - part #0
15c16
< /tmp/myfile: No such file or directory
---
> /tmp/myfile: Invalid argument

Files

log_open_sds_enabled_pool_org.txt
log_open_sds_enabled_pool_mod.txt

[grom72]

Suggested change

	CORE_LOG_HARK("PMEM feature disabled: SDS_at_create=%d", arg_in);
	CORE_LOG_HARK("PMEM feature disabled: SDS_at_create=0");

[janekmi]

Done.

[grom72]

Shall we enable SDS for opening if initially disabled?

[janekmi]

Done.

[janekmi]

@janekmi reviewed 3 of 4 files at r1, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)

[janekmi]

Done.

[janekmi]

Done.

[grom72]

@grom72 reviewed 1 of 4 files at r1, 5 of 7 files at r5, all commit messages.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion (waiting on @janekmi)

[grom72]

Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @janekmi)

[janekmi]

@janekmi reviewed 2 of 7 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)