fixed #478 - fail builds in CI on compiler warnings #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
werror-x
branch
3 times, most recently
from
a398b58 to
0e016ed
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
commented
Aug 4, 2025
| - dir | ||
| - 'CALL "C:\Program Files (x86)\Microsoft Visual Studio %VisualStudioVersion%\VC\vcvarsall.bat" %vcvarsall_platform%' | ||
| - set _CL_=/WX |
There was a problem hiding this comment.
This needs to be specified explicitly because the CMake version in Appveyor is not yet supported the canonical CMake option:
CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_COMPILE_WARNING_AS_ERROR
I left the CMake option intact for consistency with other invocations.
This comment was marked as resolved.
This comment was marked as resolved.
danmar
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.