Fix unused filename parameter TODO in reportProgress #7781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNL10
force-pushed
the
fix-unused-filename-parameter-todo
branch
from
35dc158 to
7f22b5f
Compare
GNL10
changed the title
|
|
Thanks for your contribution. That TODO might have been a bit overzealous (I probably added it). The progress is currently barely useful (need to look up the known shortcomings) and this would actually remove the context of the data generated. So if you were to utilize this is in a GUI and were using multiple threads/processes it would render it useless. I let somebody chime on here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the filename parameter in reportProgress, since it is not used anywhere.