Skip to content

Conversation

danmar
Copy link
Owner

@danmar danmar commented Aug 28, 2025

No description provided.

danmar added 2 commits August 28, 2025 21:08
…sure that the same commands are used in CI and in runformat
@danmar danmar requested a review from firewave August 28, 2025 19:09
Copy link

@@ -51,4 +51,3 @@ formatCplusplus lib/
formatCplusplus oss-fuzz/
formatCplusplus test/
formatCplusplus tools/
formatCplusplus samples/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove it here then you also do not need to apply any of the changes.

Also we lack frontend here...

Comment on lines -148 to +149
// cppcheck-suppress invalidContainerLoop
data.clear();
// cppcheck-suppress invalidContainerLoop
data.clear();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a scope here.

data.insert(i);
data.insert(i);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a scope.

@danmar danmar marked this pull request as draft August 29, 2025 07:46
@danmar
Copy link
Owner Author

danmar commented Aug 29, 2025

@firewave thanks for reviewing. I am hoping that @jcfr might publish a better PR soonish so I make this a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants