feat: Add Ember.js icon to skills #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember.js is a productive, battle-tested JavaScript framework for building modern web applications.
|
@LachyTech is attempting to deploy a commit to the danielcranney's projects Team on Vercel. A member of the Team first needs to authorize it. |
LachyTech
commented
Sep 9, 2024
| name: "Ember.js", | ||
| path: "https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/emberjs-colored.svg", | ||
| darkPath: | ||
| "https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/emberjs-dark.svg", |
There was a problem hiding this comment.
I should remove this path as the coloured icon would be suitable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds icons for the Ember.js frontend framework.
This is my first contribution to this project, please let me know if some adjustments are needed.