added spring boot icon #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@its-me-ojas is attempting to deploy a commit to the danielcranney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @danielcranney , Could you please review my recent pull request? Thanks |
LachyTech
reviewed
Sep 1, 2024
styles/globals.css
Outdated
| @@ -520,6 +520,12 @@ Table Of Contents: | |||
| .express.colored { | |||
| @apply bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/express-colored.svg')] dark:bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/express-colored-dark.svg')]; | |||
| } | |||
| springboot { | |||
There was a problem hiding this comment.
This needs to be .springboot to work correctly as a CSS class.
LachyTech
reviewed
Sep 1, 2024
styles/globals.css
Outdated
| @apply bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/springboot.svg')] dark:bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/springboot-dark.svg')]; | ||
| } | ||
| .springboot.colored { | ||
| @apply bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/springboot-colored.svg')] dark:bg-[url('https://raw.githubusercontent.com/danielcranney/readme-generator/main/public/icons/skills/springboot-colored.svg')]; |
There was a problem hiding this comment.
You don't need the dark:bg attribute if there is only one coloured icon.
LachyTech
suggested changes
Sep 1, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Please only include changes that are relevant to the change being submitted.
|
@LachyTech I've implemented the suggested changes. Please review the updates and let me know if there's anything else to address. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Related Issue: