Fix Elixir 1.17 warnings about fn parentheses #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these runtime warnings:
warning: using map.field notation (without parentheses) to invoke function ExTwilio.ResultStreamTest.Resource.resource_collection_name() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/result_stream.ex:42: ExTwilio.ResultStream.fetch_page/3
warning: using map.field notation (without parentheses) to invoke function ExTwilio.ApiTest.Resource.parents() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:88: ExTwilio.UrlGenerator.add_segments/4
warning: using map.field notation (without parentheses) to invoke function ExTwilio.UrlGeneratorTest.Resource.resource_name() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:91: ExTwilio.UrlGenerator.add_segments/4
warning: using map.field notation (without parentheses) to invoke function ExTwilio.ResultStreamTest.Resource.children() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:94: ExTwilio.UrlGenerator.add_segments/4
warning: using map.field notation (without parentheses) to invoke function ExTwilio.ApiTest.Resource.parents() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:187: ExTwilio.UrlGenerator.build_query/2
warning: using map.field notation (without parentheses) to invoke function ExTwilio.UrlGeneratorTest.Resource.children() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:190: ExTwilio.UrlGenerator.build_query/2
warning: using map.field notation (without parentheses) to invoke function ExTwilio.Account.resource_name() is deprecated, you must add parentheses instead: remote.function()
(ex_twilio 0.10.0) lib/ex_twilio/url_generator.ex:220: ExTwilio.UrlGenerator.segment/2
|
knock knock. please pull this in @danielberkompas |
|
@danielberkompas are you available to merge this pr? Thanks! |
|
@danielberkompas would be great to merge if we could! :) |
|
abandonware? time to fork @lolo-frank @joevandyk ? |
|
Can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these runtime warnings: