Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonar: Add Sonar config #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sonar: Add Sonar config #21

wants to merge 1 commit into from

Conversation

echarrod
Copy link
Collaborator

@echarrod echarrod commented Mar 5, 2025

Added

  • Sonar config

Copy link

github-actions bot commented Mar 5, 2025

Messages
📖 1 new files added!
📖 0 files modified!

Generated by 🚫 dangerJS against 3283d72

@echarrod
Copy link
Collaborator Author

echarrod commented Mar 5, 2025

@dbgrandi @f-meloni @KrauseFx @macklinu @orta do we have an existing tool on the org for flagging:

  • security issues
  • bugs
  • code coverage changes on MRs
  • code coverage overall
  • code smells
  • duplicated lines

Was going to add SonarQube Cloud, but would be open to any similar tools 👍

Would then add badges, e.g. this on https://github.com/luno/workflow/:

image

And Sonar would comment on MRs if we added the integration (can choose to opt-in by repo if we wish):

image

@orta
Copy link
Member

orta commented Mar 5, 2025

Nope, only the defaults provided by GitHub - you're welcome to use what works for you!

@echarrod
Copy link
Collaborator Author

echarrod commented Mar 6, 2025

OK thanks, have requested SonarCloud be added. Just went with this repo for now, rather than all of them! Can add them on a per-repo basis, if we want to 👍

@echarrod
Copy link
Collaborator Author

Is anyone able to approve the organisation-level request to add SonarCloud to this repo? 🙏

@echarrod
Copy link
Collaborator Author

@dbgrandi @f-meloni @KrauseFx @macklinu @orta wondering if someone can approve the Org request to add Sonar, I just added it to this repo for now 🙏

@echarrod echarrod requested a review from Copilot April 1, 2025 10:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • sonar-project.properties: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants