Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 15, 2025

Describe your changes
In napari, the edge_color attribute for layers like Points and Shapes has been deprecated as of napari 0.5.0. It has been renamed to border_color. This PR renames the keyword arguments.

Type of update
Is this a:

  • update

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
https://napari.org/dev/api/napari.Viewer.html#napari.Viewer.add_points

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Aug 15, 2025

Here's the code health analysis summary for commits 447f2ab..59939f5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

seems to have been deprecated
@HaleySchuhl HaleySchuhl added ready to review Ready for code review merge in order Set of PRs that need to be merged sequentially bugfix Bug fixes cleanup Code quality updates labels Aug 15, 2025
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HaleySchuhl HaleySchuhl merged commit 2ce9914 into main Aug 18, 2025
5 checks passed
@HaleySchuhl HaleySchuhl deleted the napari-deprecation-updates branch August 18, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fixes cleanup Code quality updates merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants