Skip to content

Conversation

candleindark
Copy link
Member

@candleindark candleindark commented Jun 4, 2025

This issue is replaced by #2430

This PR makes the instance config as defined in dandischema.conf, per dandi/dandi-schema#294, available through the api/info/ endpoint. The instance config, presented as serialized JSON object, can be reconstructed by calling model_validate or model_validate_json on dandischema.conf.Config.

Release Notes

This PR makes the instance config as defined in dandischema.conf, per dandi/dandi-schema#294, available through the api/info/ endpoint.

@yarikoptic
Copy link
Member

Testing failed since PR comes from fork. @candleindark did you test locally? should I resend from within this repo branch?

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Jun 5, 2025
@candleindark candleindark force-pushed the rf-jsonschema-runtime-instance-config branch from ddb5872 to d776b59 Compare July 7, 2025 01:33
@candleindark
Copy link
Member Author

Testing failed since PR comes from fork. @candleindark did you test locally? should I resend from within this repo branch?

@yarikoptic No, I haven't tested the solution yet (the solution is incomplete). Thanks for letting me know about the cause of the failure.

I would like to send a PR from this repo. However, I don't have write permission to this repo. Would you grant me the needed permission?

@yarikoptic
Copy link
Member

added you to https://github.com/orgs/dandi/teams/dandiarchive/members (attn note @dandi/archive-admin )

@jjnesbitt
Copy link
Member

Where is the branch/fork that adds this get_instance_config function to dandischema?

@candleindark
Copy link
Member Author

Where is the branch/fork that adds this get_instance_config function to dandischema?

It is at dandi/dandi-schema#294.

@candleindark candleindark force-pushed the rf-jsonschema-runtime-instance-config branch from d776b59 to 21efb6b Compare July 7, 2025 20:25
@candleindark candleindark changed the title Have the /info/ endpoint provide instance config info Have the /info/ endpoint provide instance config info (replaced) Jul 8, 2025
@candleindark candleindark changed the title Have the /info/ endpoint provide instance config info (replaced) Have the api/info/ endpoint provide instance config info (replaced) Jul 8, 2025
@candleindark
Copy link
Member Author

candleindark commented Jul 8, 2025

Testing failed since PR comes from fork. @candleindark did you test locally? should I resend from within this repo branch?

I don't think the failures result from this PR being sent from another repo. #2430 produces the same failures. The failures are due to the dandischema dependency is not pointing the correct version, the devendorize branch, and, potentially, not setting the proper instance config via env vars that compatible with the existing tests.

Digging deeper ...

These variables are needed to set the
instance config of the DANDI service
instance
Set env vars config instance to the DANDI DANDI instance
for running the existing tests
To include the output of instance config
value
@candleindark candleindark changed the title Have the api/info/ endpoint provide instance config info (replaced) Have the api/info/ endpoint provide instance config info Jul 8, 2025
@candleindark candleindark changed the title Have the api/info/ endpoint provide instance config info Have the api/info/ endpoint provide instance config info (repalced) Jul 8, 2025
@candleindark
Copy link
Member Author

Testing failed since PR comes from fork. @candleindark did you test locally? should I resend from within this repo branch?

I don't think the failures result from this PR being sent from another repo. #2430 produces the same failures. The failures are due to the dandischema dependency is not pointing the correct version, the devendorize branch, and, potentially, not setting the proper instance config via env vars that compatible with the existing tests.

Digging deeper ...

Never mind. @yarikoptic You were right initially. The CI for backend GitHub action does require the access to secrets and most likely requires the PR to be coming from this repo. I will use #2430 instead.

@candleindark
Copy link
Member Author

This is to be replaced by #2430 as discussed above.

@candleindark candleindark changed the title Have the api/info/ endpoint provide instance config info (repalced) Have the api/info/ endpoint provide instance config info (replaced) Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants