-
Notifications
You must be signed in to change notification settings - Fork 16
Have the api/info/
endpoint provide instance config info (replaced)
#2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have the api/info/
endpoint provide instance config info (replaced)
#2396
Conversation
Testing failed since PR comes from fork. @candleindark did you test locally? should I resend from within this repo branch? |
ddb5872
to
d776b59
Compare
@yarikoptic No, I haven't tested the solution yet (the solution is incomplete). Thanks for letting me know about the cause of the failure. I would like to send a PR from this repo. However, I don't have write permission to this repo. Would you grant me the needed permission? |
added you to https://github.com/orgs/dandi/teams/dandiarchive/members (attn note @dandi/archive-admin ) |
Where is the branch/fork that adds this |
It is at dandi/dandi-schema#294. |
d776b59
to
21efb6b
Compare
/info/
endpoint provide instance config info/info/
endpoint provide instance config info (replaced)
/info/
endpoint provide instance config info (replaced)api/info/
endpoint provide instance config info (replaced)
I don't think the failures result from this PR being sent from another repo. #2430 produces the same failures. The failures are due to the Digging deeper ... |
These variables are needed to set the instance config of the DANDI service instance
Set env vars config instance to the DANDI DANDI instance for running the existing tests
To include the output of instance config value
api/info/
endpoint provide instance config info (replaced)api/info/
endpoint provide instance config info
api/info/
endpoint provide instance config infoapi/info/
endpoint provide instance config info (repalced)
Never mind. @yarikoptic You were right initially. The |
This is to be replaced by #2430 as discussed above. |
api/info/
endpoint provide instance config info (repalced)api/info/
endpoint provide instance config info (replaced)
This issue is replaced by #2430
This PR makes the instance config as defined in
dandischema.conf
, per dandi/dandi-schema#294, available through theapi/info/
endpoint. The instance config, presented as serialized JSON object, can be reconstructed by callingmodel_validate
ormodel_validate_json
ondandischema.conf.Config
.Release Notes
This PR makes the instance config as defined in
dandischema.conf
, per dandi/dandi-schema#294, available through theapi/info/
endpoint.