Remove upper bound on how many bytes/characters can be read #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limit was added to prevent people creating arbitrarily large buffers (for instance, handle.read(2^31) would create a 2GB char array). For "large" counts, we now read in blocks of size 8192, adding to an extendable buffer.
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…unlimited-reads Remove upper bound on how many bytes/characters can be read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit was added to prevent people creating arbitrarily large buffers (for instance,
handle.read(2^31)would create a 2GB char array). For "large" counts, we now read in blocks of size 8192, adding to an extendable buffer.See also cc-tweaked/CC-Tweaked#29