-
Notifications
You must be signed in to change notification settings - Fork 4
Tickets API Swagger UI도 웹으로 발행 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GitHub Actions를 이용해 Tickets API의 Swagger UI 문서를 만들고, GitHub Pages로 배포.
Walkthrough빌드 및 배포 워크플로우의 이름이 "Generate document for todo-app"에서 "Build and Deploy"로 변경되었습니다. 또한, Tickets API용 Swagger UI를 생성하는 새로운 스텝이 추가되었고, 기존 Todo App의 Swagger UI 생성 스텝의 이름도 "Generate Swagger UI for Todo App"로 업데이트되었습니다. 추가로, Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as 개발자
participant CI as GitHub Workflow
participant Todo as Todo App Swagger UI 스텝
participant Tickets as Tickets API Swagger UI 스텝
Dev->>CI: Build and Deploy 워크플로우 트리거
CI->>Todo: Todo App Swagger UI 생성 실행
Todo-->>CI: 완료 응답
CI->>Tickets: Tickets API Swagger UI 생성 실행 (출력 디렉토리: public/tickets)
Tickets-->>CI: 완료 응답
CI->>Dev: 워크플로우 전체 완료 알림
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ahastudio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a significant enhancement by automating the generation and deployment of Swagger UI documentation for the Tickets API. Utilizing GitHub Actions, the workflow creates the Swagger UI documentation and publishes it to GitHub Pages, making it readily accessible via a dedicated URL. The primary change involves updating the README.md file to include a link to the deployed Swagger UI, thereby improving discoverability and ease of access for developers.
Highlights
- Swagger UI Deployment: Automates the generation and deployment of Swagger UI documentation for the Tickets API using GitHub Actions.
- GitHub Pages Publication: Publishes the generated Swagger UI to GitHub Pages, providing a stable and accessible URL.
- README Update: Updates the
README.mdfile to include a direct link to the deployed Swagger UI, enhancing discoverability.
Changelog
- tickets/README.md
- Added a link to the deployed Swagger UI documentation on GitHub Pages.
- The link is: https://dal-lab.github.io/openapi-sample/tickets
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A web of APIs,
Swagger's UI, a clear guide,
Docs now online, free.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces the deployment of Swagger UI documentation for the Tickets API using GitHub Actions and GitHub Pages. This is a great addition for making the API more accessible and user-friendly.
Merge Readiness
The pull request is a valuable addition to the project, providing easy access to the API documentation. The change itself is quite small, adding a link to the Swagger UI in the README. I recommend merging this pull request as is, as it enhances the usability of the Tickets API. I am unable to directly approve the pull request, and recommend that other reviewers also review this code before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/build-and-deploy.yml:20
- This PR focuses on enabling Swagger UI for the Tickets API, yet the workflow still includes a step for the Todo App. Please verify if this step is still required or if the naming should reflect support for multiple APIs.
- name: Generate Swagger UI for Todo App
GitHub Actions를 이용해 Tickets API의 Swagger UI 문서를 만들고, GitHub Pages로 배포.
Summary by CodeRabbit