-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Initial implementation of Melee damage as a stat on weapons (for glaives) #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I need updated data for weapon_formulas, as some of it is definitely not correct. |
src/perks/lib.rs
Outdated
} | ||
impl DamageModifierResponse { | ||
// damage modifier that affects all damage types | ||
pub fn basic_dmg_mod(modifier: f64) -> Self { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, more ergonomic perk creation is something that should be pursued like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, more ergonomic perk creation is something that should be pursued like this
If needed I can pull this out into its own PR as well to reduce how many changes are in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and put these changes in #112, after which I'll rebase this
It would have been great if the |
I would almost say just pulling 11393bc into a separate pr would be worth it to an extent, also this may be out of the scope right now but |
Moved the Default::default changes into #107, will need to rebase this after that gets merged. |
e1235c8
to
218c98b
Compare
Last thing remaining is Vexcalibur ranged damage numbers and then this should be good to go |
c3a1b20
to
892d146
Compare
8a1978e
to
effe8b5
Compare
d141718
to
fa1690a
Compare
7240d1a
to
815185d
Compare
…r glaives) Adds melee and pve_melee to FiringData Adds melee and pve_melee (with default 0) to SubFamJson Adds melee_dmg_scale to DamageModifierResponse and basic_dmg_mod Adds melee_dmg to DamageProfile Adds Wasm bindings for melee damage
Also involves converting Winterbite's damage entirely to Explosive damage (there is no impact damage for the shot)
Adds melee and pve_melee to FiringData
Adds melee and pve_melee (with default 0) to SubFamJson
Adds melee_dmg_scale to DamageModifierResponse
Add melee_dmg to DamageProfile
Close To Melee, Vexcalibur/Winterbite perks, updated empowering damage modifiers, Triton Vice, Wormgod Caress, Winter's Guile, and Banner of War are all handled.
The intended UI experience is that Melee damage is only shown if it is nonzero for a weapon's damage profile. We could also go with it only being shown if it is not equal to a Guardian's default punch damage, for the sake of showing it when One-Two Punch and other melee buffs have been proc'd, but then the melee damage indicator would no longer be tied to the weapon being displayed. Limiting it to Glaives (for now) keeps it relevant to the current weapon's damage profile.
Sources:
Glaive interaction spreadsheet: https://docs.google.com/spreadsheets/d/1FT-BL6UA6ntNEN7_btqwlfJaPYTAeIFvlhpkvWHTajc/edit?usp=sharing
Damage stacking spreadsheet: https://docs.google.com/spreadsheets/d/1i1KUwgVkd8qhwYj481gkV9sZNJQCE-C3Q-dpQutPCi4/edit#gid=242217075
light.gg
amoral_support and oni_black_mage's testing
Mossy's spreadsheet: https://docs.google.com/spreadsheets/d/1b57Hb8m1L3daFfUckQQqvvN6VOpD03KEssvQLMFpC5I/