fix: silence dbus errors in CI / Docker #32479
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/silence-dbus-errors
|
| Run status |
|
| Run duration | 17m 52s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
791
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
61.84%
|
|
|---|---|
|
Untested elements
|
27
|
|
Tested elements
|
47
|
Accessibility
99.02%
|
|
|---|---|
|
Failed rules
|
0 critical
3 serious
1 moderate
0 minor
|
|
Failed elements
|
19
|
AtofStryker
approved these changes
Sep 12, 2025
| @@ -143,6 +144,11 @@ const spawnModule = { | |||
| args.unshift(process.env.CYPRESS_INTERNAL_DEV_DEBUG) | |||
| } | |||
|
|
|||
| if (ci.isCI) { | |||
| debug('disabling dbus in CI') | |||
| stdioOptions.env.DBUS_SESSION_BUS_ADDRESS = 'disabled:' | |||
There was a problem hiding this comment.
I wish we had a different way to verify this in the current branch than just the snapshot value. We can also add a test once #32416 makes its way into develop
There was a problem hiding this comment.
Let's hold off on a merge here until #32416 , at which point I'll amend this pr with a test
|
If the fix only applies to CI, then it should not close #32290, since this also describes the garbage error occurring in Cypress Docker images, when used locally (not in CI). |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cacieprins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With Cypress 15, we cleaned up how we filter data that gets streamed to
stderr. Unfortunately, some of the previously filtered (benign) error messages slip through in certain situations. This is especially noticeable in Cypress' own CI, where we launch cypress from source rather than via the built binary.One of these classes of error messages relate to Electron trying to connect to dbus. Dbus is an IPC system typically used for desktop related operations, like the system tray, notifications, and so forth. CI environments do not typically have dbus, nor do they need it.
This PR prevents Electron from trying to connect to dbus by explicitly disabling it via an environment variable, when a CI environment is detected.
Steps to test
Verify that the driver e2e tests on this PR do not write dbus error messages to the console in CI.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?