chore: use circleci cli to package ci configurations #32462

cacieprins · 2025-09-10T19:43:19Z

Closes

Additional details

While the line count of the main workflows.yml has increased quite a bit, this is because circleci config pack unrolls/expands all anchors in the source yml files.

circleci config pack uses the FYAML convention to be able to break yaml files into smaller, easier to digest chunks.

This PR:

migrates workflows.yml to .circleci/src/workflows
defines a new pull-request workflow, which at the moment is identical to linux-x64 except it does not include references to any of the jobs excluded by the main build filters
migrates config.yml to .circleci/src/config
adds a husky pre-commit hook to pack directories in .circleci/src to a yaml file defined by the directory name in .circleci/
additionally, runs circleci config validate on these packed yml files, to ensure that they are valid circleci configs

Steps to test

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

…cleci config pack to compose them into the main workflows.yml file

cypress · 2025-09-12T16:02:24Z

cypress Run #65552

Run Properties: Failed #65552 • 95ebbd1b1e: fix export

Project	`cypress`
Branch Review	`use-pack-for-circle`
Run status	`Failed #65552`
Run duration	`39m 29s`
Commit	`95ebbd1b1e: fix export`
Committer	`Cacie Prins`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`5`
Pending	`1012`
Skipped	`0`
Passing	`19068`
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage `44.99%`
Untested elements	`187`
Tested elements	`157`

Accessibility `97.7%`
Failed rules	`4 critical` `8 serious` `2 moderate` `2 minor`
Failed elements	`109`

Tests for review

src/components/Collapsible.cy.tsx • 1 failed test • frontend-shared-ct

View Output

Test		Artifacts
An uncaught error was detected outside of a test		`Test Replay`

commands/files.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts

src/cy/commands/files > #readFile > retries to read when ENOENT

    </td>
  </tr></table>

commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts

... > stops waiting when an xhr request is canceled

    </td>
  </tr></table>

commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta

View Output

Test		Artifacts
... > errors > throws when waiting for 2nd response to route		`Test Replay`

cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating away from the /specs to /runs		`Test Replay` `Screenshots`

react.cy.ts • 1 flaky test • vite-dev-server

View Output

Test		Artifacts
Working with vite5.4.18-react > MissingReact: should fail, rerun, succeed		`Test Replay` `Screenshots`

.husky/pre-commit

cacieprins · 2025-09-16T15:35:14Z

packages/electron/test/open.spec.ts

@@ -278,7 +278,7 @@ describe('open', () => {
        errCb(err)

        expect(process.exit).toHaveBeenCalledWith(1)
-        // eslint-disable-next-line no-console
+


linting was failing without these changes

cacieprins · 2025-09-16T15:36:30Z

.circleci/src/workflows/workflows/pull-request.yml

+            value: << pipeline.git.branch >>
+    - not:
+        matches:
+            pattern: /^pull\/[0-9]+/


contributor prs still use the contributor linux-x64 workflow, for now. for an idea about how we can simplify that: #32494

… commit

AtofStryker · 2025-09-16T16:22:51Z

.circleci/src/workflows/@workflows.yml

@@ -0,0 +1,2844 @@
+version: 2.1
+
+chrome-stable-version: &chrome-stable-version "140.0.7339.127"


The github action likely needs to be updated that was originally updating the .circleci/workflow file for the latest browser version. We are also using the yaml package to format the config. I did some work to port it over in https://github.com/cypress-io/cypress/pull/30989/files so hopefully that paints enough context if/what needs to change

Updated the scripts & left a comment that updating them is necessary in 5fb5125

…ct file

cacieprins added 7 commits September 9, 2025 13:54

add husky script to build circleci yml files

e66e778

add circleci cli as a required tool for working with .circleci

bf75cda

break the original workflows.yml file into separate pieces, using cir…

b1aeba4

…cleci config pack to compose them into the main workflows.yml file

fix pull request workflow def

d7dd504

more robust precommit for circleci packing

2caafba

even nicer stdout for precommit :)

7e4285f

allow pr pipeline on this branch

bdb8194

cacieprins marked this pull request as draft September 10, 2025 19:43

cacieprins added 2 commits September 11, 2025 10:23

split up the config.yml to demonstrate more fully

79c4d96

Merge branch 'develop' into use-pack-for-circle

36895e0

cacieprins marked this pull request as ready for review September 12, 2025 15:29

Merge branch 'develop' into use-pack-for-circle

c5c623c

cacieprins added 2 commits September 12, 2025 16:05

fix conditional on pr pipeline

84d0529

Merge branch 'develop' into use-pack-for-circle

fa96551

jennifer-shehane assigned cacieprins Sep 15, 2025

jennifer-shehane self-requested a review September 15, 2025 15:10

Merge branch 'develop' into use-pack-for-circle

2cd55e7

cacieprins commented Sep 16, 2025

View reviewed changes

.husky/pre-commit Outdated Show resolved Hide resolved

cacieprins commented Sep 16, 2025

View reviewed changes

cacieprins requested review from mschile, AtofStryker and ryanthemanuel September 16, 2025 15:39

cacieprins added 4 commits September 16, 2025 11:40

exit 1 if circleci cli not found and circleci config files staged for…

826aa6b

… commit

use linux-x64 executor for unit-tests

51d6d0a

try using ipv6 in contributor with correct executor

59c2f2b

ensure node

5d9a7b1

AtofStryker requested changes Sep 16, 2025

View reviewed changes

update github action to update browser versions to point to the corre…

5fb5125

…ct file

cacieprins added 3 commits September 16, 2025 12:49

ensure node more times

2d2d92d

fix export

95ebbd1

reduce expected result count

4ac065b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: use circleci cli to package ci configurations #32462

chore: use circleci cli to package ci configurations #32462

Uh oh!

cacieprins commented Sep 10, 2025

Uh oh!

cypress bot commented Sep 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

cacieprins Sep 16, 2025

Uh oh!

cacieprins Sep 16, 2025

Uh oh!

AtofStryker Sep 16, 2025 •

edited

Loading

Uh oh!

cacieprins Sep 16, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,2844 @@
		version: 2.1

		chrome-stable-version: &chrome-stable-version "140.0.7339.127"

chore: use circleci cli to package ci configurations #32462

Are you sure you want to change the base?

chore: use circleci cli to package ci configurations #32462

Uh oh!

Conversation

cacieprins commented Sep 10, 2025

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Uh oh!

cypress bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cypress Run #65552

Tests for review

Uh oh!

Uh oh!

cacieprins Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

cacieprins Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

AtofStryker Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cacieprins Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cypress bot commented Sep 12, 2025 •

edited

Loading

AtofStryker Sep 16, 2025 •

edited

Loading