-
Notifications
You must be signed in to change notification settings - Fork 76
mwc integration #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mwc
Are you sure you want to change the base?
mwc integration #1016
Conversation
bc27b13
to
7537105
Compare
a91277e
to
ab525e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be reverted as this file is only for migrations of old data of which there is none for a newly added coin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be reverted as this file is only for migrations of old data of which there is none for a newly added coin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be reverted as themes have been updated to not rely on hard coded values. This legacy code remains for compatibility and will likely be removed in the future
@@ -95,6 +95,8 @@ class TransactionV2 { | |||
|
|||
bool get isEpiccashTransaction => | |||
_getFromOtherData(key: TxV2OdKeys.isEpiccashTransaction) == true; | |||
bool get isMimblewimblecoinTransaction => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert the @ignore
annotation above bool get isMimblewimblecoinTransaction =>
so build runner will ignore generating and updating the isar schema for this value. It is not needed and Isar isn't that great for automatically updating ORM stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be reverted completely due to change requested in transaction_v2.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be reverted completely due to change requested in stack_theme.dart. For more info and reasoning see comment on transaction_v2.dart
@@ -88,6 +88,17 @@ class _AddEditNodeViewState extends ConsumerState<AddEditNodeView> { | |||
ref.read(nodeFormDataProvider).host = data.host; | |||
ref.read(nodeFormDataProvider).port = data.port; | |||
ref.read(nodeFormDataProvider).useSSL = data.useSSL; | |||
} else if (coin is Mimblewimblecoin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double MWC and CryptonoteCurrency cases here
Integration of MWC into stack wallet
flutter_libmwc: https://github.com/vekamo/flutter_libmwc