Skip to content

mwc integration #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: mwc
Choose a base branch
from
Open

mwc integration #1016

wants to merge 17 commits into from

Conversation

vekamo
Copy link

@vekamo vekamo commented Nov 13, 2024

Integration of MWC into stack wallet
flutter_libmwc: https://github.com/vekamo/flutter_libmwc

@vekamo vekamo closed this Nov 13, 2024
@vekamo vekamo reopened this Nov 13, 2024
@vekamo vekamo marked this pull request as draft November 13, 2024 16:08
@vekamo vekamo marked this pull request as ready for review November 17, 2024 11:01
@vekamo vekamo force-pushed the mwc-integration branch 2 times, most recently from a91277e to ab525e8 Compare December 20, 2024 21:29
@julian-CStack julian-CStack changed the base branch from staging to mwc March 18, 2025 14:47
Copy link
Collaborator

@julian-CStack julian-CStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted as this file is only for migrations of old data of which there is none for a newly added coin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted as this file is only for migrations of old data of which there is none for a newly added coin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted as themes have been updated to not rely on hard coded values. This legacy code remains for compatibility and will likely be removed in the future

@@ -95,6 +95,8 @@ class TransactionV2 {

bool get isEpiccashTransaction =>
_getFromOtherData(key: TxV2OdKeys.isEpiccashTransaction) == true;
bool get isMimblewimblecoinTransaction =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert the @ignore annotation above bool get isMimblewimblecoinTransaction => so build runner will ignore generating and updating the isar schema for this value. It is not needed and Isar isn't that great for automatically updating ORM stuff.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted completely due to change requested in transaction_v2.dart

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted completely due to change requested in stack_theme.dart. For more info and reasoning see comment on transaction_v2.dart

@@ -88,6 +88,17 @@ class _AddEditNodeViewState extends ConsumerState<AddEditNodeView> {
ref.read(nodeFormDataProvider).host = data.host;
ref.read(nodeFormDataProvider).port = data.port;
ref.read(nodeFormDataProvider).useSSL = data.useSSL;
} else if (coin is Mimblewimblecoin) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double MWC and CryptonoteCurrency cases here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants