Skip to content

🤖 Merge 1.8.x-sync into master #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2025
Merged

🤖 Merge 1.8.x-sync into master #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fe37ba
Fixing memory leak (#740)
ChrisPaulBennett Oct 30, 2025
5e4610a
changelog
oliver-sanders Oct 30, 2025
77843ec
Merge pull request #747 from oliver-sanders/740.backport
ChrisPaulBennett Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes.d/740.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve the logic for handling closed connections. This results in better memory management.
7 changes: 4 additions & 3 deletions cylc/uiserver/graphql/tornado_ws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,10 @@ async def receive(self):
raise ConnectionClosedException()

async def send(self, data):
if self.closed:
return
await self.ws.write_message(data)
if self.ws.ws_connection and not self.ws.ws_connection.is_closing():
await self.ws.write_message(data)
else:
raise WebSocketClosedError

@property
def closed(self):
Expand Down
Loading