two-first-end-points #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| player.user_id = i[:userId] | ||
| player.correct_questions = i[:correctQuestions] | ||
| player.incorrent_questions = i[:incorrectQuestions] | ||
| player.tournament_id = tournament.tournament_id |
There was a problem hiding this comment.
This is very confusing - the Rails convention would be that player.tournament_id would hold tournament.id, not tournament.tournament_id
That's how ActiveRecord knows how to find it in the DB with the belongs_to relation
| class TournamentsController < ApplicationController | ||
| skip_before_action :verify_authenticity_token | ||
|
|
||
| def saveTournamentResults |
There was a problem hiding this comment.
Always use snake_case - same goes for all of the other endpoints
Suggested change
| def saveTournamentResults | |
| def save_tournament_results |
Owner
Author
There was a problem hiding this comment.
how its can be?
how you can config a route with snake_case? there is a way to configure route as usual and route it to the controller with snake_case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.