Skip to content

Automated Data Collection #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

alairon
Copy link
Contributor

@alairon alairon commented May 9, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Enables Github Actions

What is the current behavior?

  • Data is currently manually collected and added onto GitHub on a biweekly basis

What is the new behavior?

  • Data collecting and processing will now be completely automated
    • This PR enables a GitHub Action workflow that runs every Wednesday around 09:00 UTC. This usually occurs during the game's weekly maintenance
      • It can also be activated manually from the Actions tab
    • The workflow will automatically preserve the previous week's data and write the new data into the repo
    • If data couldn't be collected or parsed, the existing data files will not be modified

Does this introduce a breaking change?

  • Yes, potentially
  • No

This relies on the data source being online during the data collection process. If the process fails for two consecutive weeks, then there is a chance the website will not have data to present.

Edit: The workflow can now be manually activated

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lostarktimer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 3:55am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant