Time-based Bugfixes

[alairon]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Alarms

• Users looking at events happening the following day after the page loads will always initially be told that events are happening "in 23 hours". This is because time is calculated relative to when the user initially accessed the page.
• The automatic date changer changes dates when the local current time hits midnight. For users with time zone that does not line up with the selected server's time zone, this can cause unexpected behavior when either the local or server date changes. Note that these issues can currently be resolved manually by clicking on the date button, or by refreshing the page
  • Users with local times that changes the date ahead of the server will have events skipped
  • If the server changes the date ahead of the user's local time, the date will not automatically change and new events are not shown

Examples/Test Cases

• Central US players playing on US West servers (2 hours ahead) or US East servers (1 hour behind)
• Newfoundland, Canada players playing on US East servers (1.5 hours ahead)
• Irish/British players playing on EU Central servers (1 hour behind)
• New Zealand players playing on US West servers (19 hours ahead)

Merchants

• [Bug]: Merchants next spawn time(r) doesn't reset without page refresh #3
  This is caused when the tables are not refreshed. Currently, tables will not refresh unless:
  1. The app receives new data from SaintBot
  2. The user modifies the site's settings (server, region, 24 hour, localized time, etc.)

What is the new behavior?

Alarms

• Changed the selected date's reference point to midnight server time
• The automatic date changer will now switch dates when the server does

Merchants

• Fixes [Bug]: Merchants next spawn time(r) doesn't reset without page refresh #3: the app will now forcefully refresh the tables when merchants are expected to spawn
  • Changed data management to be based on serverTime rather than currDate

Does this introduce a breaking change?

• Yes
• No

Alarms

While not a new issue, users will still not be given any notification(s) ahead of time for certain events that happen right as the server date changes.

Merchants

As the WebSocket is only available on the production build, it is not possible to determine if this will cause a breaking change. The change only modifies the graphical features from Issue 3 and should not cause any breaking changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lostarktimer	✅ Ready (Inspect)	Visit Preview	Jul 23, 2022 at 3:38AM (UTC)