Allow the admin deployment to be disabled #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganwitt
force-pushed
the
allow_admin_to_be_disabled
branch
from
51bd81d to
92cec70
Compare
keeganwitt
force-pushed
the
allow_admin_to_be_disabled
branch
from
92cec70 to
6a9a40e
Compare
|
There are more resources that can be turned off if the this is not a cluster but standalone runtime nodes:
#36 is pretty similar but hasn't been completed IMO so it is still under review. Take a look there too if you can and make the adjustments. Thank you! |
|
Yea, I think that other PR would satisfy this requirement. We can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the runtime doesn't require the admin deployment, the chart should allow users to opt out of having it.