fix call function with a nil value error #3863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Please note that this code is copied/vendored from https://cs.opensource.google/go/x/tools, so we didn't write the code nor do we really maintain it right now. You should direct your fix there, if the bug is still present upstream. I'll leave it to @myitcv to decide if the fix here is useful, i.e. if this bit of code is used by |
|
Hi @alingse . Thank you for the PR. I'd like to merge this, but we need you to follow the instructions for providing a Developer Certificate of Origin before we can proceed. |
Signed-off-by: alingse <[email protected]>
|
@cuematthew done, I push a signed commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also https://go-review.googlesource.com/c/tools/+/661695